Conversation
Test✅ Successful test. Usage ExplanationNOTE - I edited this because a future PR will move the setting into General Settings to update the soon-to-be added Treatment tables and Statistics charts. I'll be grabbing these words as a first draft for the LoopFollowDocs updates. In the LoopFollow Settings, chose General Settings and tap on Time Zone Override.
ConfigurationStart with dev on the LoopFollow phone, iPhone 8 running iOS16
For later testing, update to code this PR for that same phone. Common TimezoneConfigure so LoopFollow phone follows a Loop URL with both phones in the same timezone.
Timezone more negative wrt UTCModify the LF phone to be in a different timezone
Timezone more positive wrt UTCModify the LF phone to be in a different timezone
Repeat with a Trio URLsimilar success |
marionbarker
left a comment
There was a problem hiding this comment.
Code review was already approved.
Test was successful.
LGTM
|
I pushed a linting change from when I built this branch. |
This change allows overriding the time zone used for the graph.
Backstory: When traveling for work and monitoring my son's numbers remotely, I get confused when the graph uses my time zone instead of his. I prefer to set it to his time zone, so it aligns with his sleep time, meal time, etc.
I added a setting under Graph Settings to override the graph time zone:
For example, if I'm in London and my son is in San Francisco:
before

after

Note: When the time zone override is changed,
markDirty()forces the time axis update. The pills on the graph points don't get updated immediately and require an app reload — this is consistent with how the graph behaves currently on the actual time zone changes, so I kept it that way.